Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add OPUS mp4 support #143

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

Chokoabigail
Copy link
Contributor

@Chokoabigail Chokoabigail commented Sep 8, 2023

Always use mp4 for opus

@google-cla
Copy link

google-cla bot commented Sep 8, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Chokoabigail Chokoabigail changed the title Add OPUS mp4 support feat: Add OPUS mp4 support Sep 8, 2023
@joeyparrish
Copy link
Member

@Chokoabigail, can you please check this page and take care of Google's CLA requirement? https://github.com/shaka-project/shaka-streamer/pull/143/checks?check_run_id=16608765464

Thanks for your contribution!

@Chokoabigail
Copy link
Contributor Author

Hi, I solved Google's CLA requirement, can you marge this please?

@joeyparrish joeyparrish merged commit 2f38022 into shaka-project:main Sep 11, 2023
4 of 5 checks passed
@joeyparrish
Copy link
Member

Thanks for your contribution!

@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Nov 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants