Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix typing of log_request #166

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

joeyparrish
Copy link
Member

This mistake slipped through because we are not yet validating every PR with mypy.

This mistake slipped through because we are not yet validating every PR with mypy.
@mariocynicys
Copy link
Contributor

This mistake slipped through because we are not yet validating every PR with mypy.

But I see we do lint check the code in the end-to-end tests:

type_check_result = mypy_api.run(['streamer/'])
if type_check_result[2] != 0:
print('The type checker found the following errors: ')
print(type_check_result[0])
return 1

@joeyparrish
Copy link
Member Author

This mistake slipped through because we are not yet validating every PR with mypy.

But I see we do lint check the code in the end-to-end tests:

Yes, and soon I intend to revive the workflows that run those tests. I am also going to build release workflows, like those we have for most of the other shaka-project repos.

@joeyparrish joeyparrish merged commit c38d7e9 into shaka-project:main Oct 24, 2024
3 checks passed
@joeyparrish joeyparrish deleted the fix-typing branch October 24, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants