fix(binaries): Fix arm64 mac binary tags #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I used docs on the [Python wheel format][] to determine that the bit with the OS and CPU is called the "platform tag". Then I found a [discussion of macOS platform tags][] that gave me the hint that arm64 wheels need to specify macOS 11 at a minimum. [Python wheel format]: https://peps.python.org/pep-0427/ [discussion of macOS platform tags]: pypa/wheel#387 Closes shaka-project#194
joeyparrish
requested review from
avelad,
theodab and
mariocynicys
and removed request for
avelad
avelad
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used docs on the Python wheel format to determine that the bit with the OS and CPU is called the "platform tag". Then I found a discussion of macOS platform tags that gave me the hint that arm64 wheels need to specify macOS 11 at a minimum.
Closes #194