Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop "raw_images" input type #25

Closed
joeyparrish opened this issue Oct 11, 2019 · 3 comments
Closed

Drop "raw_images" input type #25

joeyparrish opened this issue Oct 11, 2019 · 3 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@joeyparrish
Copy link
Member

Now that we have "external_command" as an input type, it's no longer clear if "raw_images" offers anything unique or valuable.

Thoughts? Please comment!

If nobody has an opinion on this, I may drop it soon.

@joeyparrish joeyparrish added the type: enhancement New feature or request label Oct 11, 2019
@shaka-bot shaka-bot added this to the Backlog milestone Oct 11, 2019
@joeyparrish joeyparrish pinned this issue Oct 15, 2019
@joeyparrish joeyparrish changed the title Consider dropping "raw_images" input type RFC: dropping "raw_images" input type Oct 15, 2019
@Romantic-LiXuefeng
Copy link

I'm not clear what is the use case for "external_command" as an input type?

@joeyparrish
Copy link
Member Author

It allows you to run an external command which generates content. For example, we use it to generate a sequence of images with an external command called Gource. That is how we generate this live stream:

https://nightly-dot-shaka-player-demo.appspot.com/demo/#asset=https://storage.googleapis.com/shaka-live-assets/player-source.mpd

Before we added "external_command", we used to do this with "raw_images" through a fifo. But that required a separate fifo and an additional script to manage it.

Also, "external_command" is more flexible because it can generate an image sequence, or video, or audio, whereas "raw_images" requires a sequence of images specifically.

So I'm struggling to come up with a good reason to keep "raw_images".

@joeyparrish joeyparrish modified the milestones: Backlog, v1.0 Oct 17, 2019
@joeyparrish
Copy link
Member Author

I'm going to go ahead with the removal of raw_images input type.

@joeyparrish joeyparrish unpinned this issue Jan 24, 2020
@joeyparrish joeyparrish changed the title RFC: dropping "raw_images" input type Drop "raw_images" input type Jan 24, 2020
@joeyparrish joeyparrish self-assigned this Feb 19, 2020
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Mar 24, 2020
@shaka-project shaka-project locked and limited conversation to collaborators Mar 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants