Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for custom bitrates and resolutions #5

Closed
joeyparrish opened this issue Aug 30, 2019 · 3 comments
Closed

Add config for custom bitrates and resolutions #5

joeyparrish opened this issue Aug 30, 2019 · 3 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@joeyparrish
Copy link
Member

Right now, the resolutions, their names, and their target bitrates for various codecs are all hard-coded. It would be nice if the user could customize these through the pipeline config.

@joeyparrish joeyparrish added the type: enhancement New feature or request label Aug 30, 2019
@joeyparrish joeyparrish modified the milestones: v1.0, Backlog Aug 30, 2019
@Brainiarc7
Copy link

Related: Support for hardware-based encoding with complex workflows (such as decode with NVDEC + encode with NVENC with multiple GPUs, where jobs are scheduled to specific GPUs, etc) will depend mostly on being able to customize FFmpeg-specific arguments in an encoder pipeline.

I see that at the moment, VAAPI-based encoding is somehow supported, but this implementation assumes platform defaults which could fail in cases where multiple VAAPI-capable devices exist or where specific VAAPI drivers need to be set, rather than relying on a hard-coded value such as i965.

Another suggestion would be to extend support for different muxer types in ffmpeg. Of major interest being tee and fifo, which would allow an end user to configure multiple outputs with different weights for latency and error resilience.

@joeyparrish
Copy link
Member Author

@Brainiarc7, that's a great point. Would you please file a separate issue to support multiple VAAPI devices at once? I think support for different ffmpeg muxers would also be a welcome feature request. But both seem separate from customizing bitrates and resolutions. Thanks!

(For what it's worth, we don't hard-code i965 anywhere in the project, but we do mention it as an example in our docs.)

@Brainiarc7
Copy link

Sure, will do!

@joeyparrish joeyparrish self-assigned this Oct 13, 2019
@joeyparrish joeyparrish modified the milestones: Backlog, v1.0 Oct 13, 2019
@joeyparrish joeyparrish changed the title Add pipeline config for custom bitrates and resolutions Add config for custom bitrates and resolutions Oct 13, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 13, 2019
@shaka-project shaka-project locked and limited conversation to collaborators Dec 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants