Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL] Add max_retry_count and wait kwargs to Command::Base#step #216

Closed
zzaakiirr opened this issue Jul 22, 2024 · 1 comment · Fixed by #217
Closed

[PROPOSAL] Add max_retry_count and wait kwargs to Command::Base#step #216

zzaakiirr opened this issue Jul 22, 2024 · 1 comment · Fixed by #217
Assignees

Comments

@zzaakiirr
Copy link
Contributor

zzaakiirr commented Jul 22, 2024

Why?

Command::Base#step with retry_on_failure: true option can enter infinite loop if block passed to this method returns falsey value

Example

This code enters infinite loop:

Command::Base.new(config).step("Infinite loop example", retry_on_failure: true) { false }

Proposal

  1. Add max_retry_count option to prevent infinite loop
  2. Add wait option so that time after which passed block should be retried can be configurable
@zzaakiirr zzaakiirr self-assigned this Jul 22, 2024
@zzaakiirr
Copy link
Contributor Author

Issue #157 can be addressed after this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant