Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Missing translations error #598

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

rameziophobia
Copy link
Contributor

@rameziophobia rameziophobia commented Aug 21, 2024

Before:
Screenshot 2024-08-21 at 3 20 52 PM

After:
Screenshot 2024-08-21 at 3 21 11 PM


This change is Reviewable

Summary by CodeRabbit

  • Improvements
    • Enhanced localization practices by updating notice messages to use symbol keys instead of string keys for comment actions (create, update, destroy).

These changes improve consistency and may enhance performance, while the overall functionality remains unchanged.

Copy link

coderabbitai bot commented Aug 21, 2024

Warning

Rate limit exceeded

@rameziophobia has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 33 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 0725de6 and a217ffa.

Walkthrough

The updates made to the comments controller involve changing the localization keys for notice messages in the create, update, and destroy actions from string literals to symbol keys. This adjustment aims to standardize the localization approach without affecting the functionality or control flow of the methods.

Changes

File Change Summary
app/controllers/comments_controller.rb Updated notice messages from string keys to symbol keys for create, update, and destroy actions, enhancing localization consistency.

Poem

🐇 In the code so bright and clear,
Symbols dance, let's give a cheer!
Localization now takes flight,
With every change, our code feels right.
Hopping forth with joyful glee,
A rabbit's code is wild and free! 🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2689a46 and 1888c1d.

Files selected for processing (1)
  • app/controllers/comments_controller.rb (3 hunks)
Files skipped from review due to trivial changes (1)
  • app/controllers/comments_controller.rb

@rameziophobia rameziophobia force-pushed the ramezweissa/fix-missing-translations-error branch from 1888c1d to 0725de6 Compare August 26, 2024 11:22
@rameziophobia
Copy link
Contributor Author

/deploy-review-app

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1888c1d and 0725de6.

Files selected for processing (1)
  • app/controllers/comments_controller.rb (3 hunks)
Files skipped from review due to trivial changes (1)
  • app/controllers/comments_controller.rb

@rameziophobia rameziophobia force-pushed the ramezweissa/fix-missing-translations-error branch from 0725de6 to 1c91d8d Compare August 26, 2024 11:30
@rameziophobia
Copy link
Contributor Author

/deploy-review-app

Copy link

We started working on your review-app deployment. You can track progress in the Actions Tab here on Github.

@rameziophobia rameziophobia force-pushed the ramezweissa/fix-missing-translations-error branch from 1c91d8d to 30f2124 Compare August 26, 2024 11:51
@rameziophobia
Copy link
Contributor Author

/deploy-review-app

Copy link

We started working on your review-app deployment. You can track progress in the Actions Tab here on Github.

@rameziophobia rameziophobia force-pushed the ramezweissa/fix-missing-translations-error branch from 30f2124 to a217ffa Compare August 26, 2024 12:15
@rameziophobia
Copy link
Contributor Author

/deploy-review-app

Copy link

We started working on your review-app deployment. You can track progress in the Actions Tab here on Github.

@rameziophobia
Copy link
Contributor Author

Review app works as expected

Screenshot 2024-08-26 at 3 23 03 PM

@rameziophobia
Copy link
Contributor Author

/deploy-review-app

Copy link

github-actions bot commented Oct 2, 2024

We started working on your review-app deployment. You can track progress in the Actions Tab here on Github.

@rameziophobia rameziophobia merged commit 3e1f722 into master Oct 2, 2024
3 checks passed
@rameziophobia rameziophobia deleted the ramezweissa/fix-missing-translations-error branch October 2, 2024 11:42
@justin808
Copy link
Member

thanks @rameziophobia !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants