Proxy regexp too aggressive

[simonburger]

I'm having issues with urls that look like http://example.com/sites/example.com/theme/style.css being rewritten to http://192.168.0.24:3002/sites/192.168.0.24:3002/theme/style.css
In proxy.js utils.rewriteLinks is using a global regular expression match. Can we make this just stop after the first match please?

[shakyShane]

Oh yeah - good catch! In the spirit of trying encourage more contributors, would you like to make a PR with some failing tests? (and a fix, if you can).

As a pointer, in test/specs/proxy/proxy.utils.js in the first describe block you could test the regex like this.

    // run 'npm test' to see everything still passes
    // This will pass
    it("should use the regex to replace links", function () {
        var rewrite = utils.rewriteLinks({host: "example.com", port: 80}, proxyUrl);
        var actual = "<a href='http://example.com'></a>".replace(rewrite.match, rewrite.fn);
        var expected = "<a href='http://192.168.0.4:3002'></a>";
        assert.equal(actual, expected);
    });

And then to replicate your issue, something like this should cause it to fail

    // This will fail - time to fix
    it("should use the regex to replace links", function () {
        var rewrite  = utils.rewriteLinks({host: "example.com", port: 80}, proxyUrl);
        var actual = "<a href='http://example.com/sites/example.com/about'></a>".replace(rewrite.match, rewrite.fn);
        var expected = "<a href='http://192.168.0.4:3002/sites/example.com/about'></a>";
        assert.equal(actual, expected);
    });

To run the tests, just fork the repo, clone it locally to your machine, run npm install and then run npm test to run the linting + tests.

Let me know if you have any problems, or if you would rather not help out :)

[simonburger]

Ok, cool. I might need a few weeks to get onto this, but I'll give it a shot.

[shakyShane]

I have this so far - seems to work, but seems to complicated

http://regexr.com/38nl6

[shakyShane]

fixed in 0.8.1 :)