Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaceCodeSettings seems backwards in some cases. Can we get an ignoreCodeSettings property that just lists settings' keys to ignore on upload? #338

Closed
chevcast opened this issue Jun 9, 2017 · 1 comment

Comments

@chevcast
Copy link

chevcast commented Jun 9, 2017

Would it be possible to get an ignoreCodeSettings option that is just an array of keys to ignore?

For example, I am using the VS Code Vim extension which has an option to delegate some tasks to Neovim if you have it installed. On Windows I have to provide a path to the Neovim executable.

"vim.neovimPath": "C:\\Windows\\SysWOW64\\Get-ToolsLocation\\neovim\\Neovim\\bin\\nvim.exe"

But then on my Macbook, my Mac Pro, and my work Mac the default value of "nvim" is sufficient because Neovim lives on my PATH as nvim. So since I don't want to set vim.neovimPath on any of my Mac machines I now have to add the following to every single Mac machine:

"replaceCodeSettings": {
  "vim.neovimPath": ""
}

What I'd rather do is just add the following to my Windows machine only:

"ignoreCodeSettings: [
  "vim.neovimPath"
]

That way I could just set ignoreCodeSettings on my Windows machine only instead of me having to set replaceCodeSettings on all my other machines. It would also be better in cases where the Code settings need to be a different value on every machine. You could just set ignoreCodeSettings on each machine and set the value to be different on each machine. The setting wouldn't even be included in the Gist and you wouldn't have to every worry about those values getting overridden.

@shanalikhan
Copy link
Owner

yes you are right,
There is already issue opened for it with the same settings you have shown.
#232 (comment)

Im closing this. Post the ideas there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants