Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Upload / Download : Disable change detection for workspace storage folder. #708

Closed
sevenryze opened this issue Nov 16, 2018 · 6 comments

Comments

@sevenryze
Copy link

🐛 Describe the bug
A clear and concise description of what the bug is.
The extension triggers upload action every time when i click activity bar or open terminal.

🌴 Visual Studio Code Version : [ 1.29.1 and latest insider build ]
🌴 Code Settings Sync Version : [ 3.2 ]
🌴 Standard or Insiders : [ both of them are tested ]
🌴 Operating System : [ windows 10 ]
🌴 Occurs On: [ Upload ]
🌴 Proxy Enabled: [ No ]
For note: I use bash on windows as external terminal

📰 To Reproduce
Steps to reproduce the behavior:

  1. Go to 'normal workspace'
  2. Click on 'any activity bar item or open terminal'
  3. See error, the status bar will show "Sync: Upload in progress, please wait"

💪 Expected behavior
Should not upload settings when i click the buttons mentioned before.

📺 Console Error Log

image

Seems like the sync extension always detects workspace storage file changes.

📺 Additional context
In my code/user folder, the syncLocalSettings.json file is there, which declares that the workspaceStorage folder should be ignored. look like this extension failed to parse the global configure file.

@shanalikhan
Copy link
Owner

which declares that the workspaceStorage folder should be ignored. look like this extension failed to parse the global configure file.

Can you post your Settings Sync global settings ( See readme where global Settings are present )

@sevenryze
Copy link
Author

{
  "ignoreUploadFiles": [
    "projects.json",
    "projects_cache_vscode.json",
    "projects_cache_git.json",
    "projects_cache_svn.json",
    "gpm_projects.json",
    "gpm-recentItems.json"
  ],
  "ignoreUploadFolders": ["workspaceStorage"],
  "ignoreExtensions": [],
  "replaceCodeSettings": {},
  "gistDescription": "Visual Studio Code Settings Sync Gist",
  "version": 322,
  "token": "*********************",
  "downloadPublicGist": false,
  "supportedFileExtensions": ["json", "code-snippets"],
  "openTokenLink": true,
  "disableUpdateMessage": false,
  "lastUpload": "2018-11-24T09:48:20.210Z",
  "lastDownload": "2018-11-22T08:31:29.459Z",
  "githubEnterpriseUrl": null,
  "askGistName": false,
  "customFiles": {},
  "hostName": null
}

Could these help you? i couldn't find any error in these settings.

@shanalikhan
Copy link
Owner

I think you have set auto upload or download is enabled.

@shanalikhan shanalikhan changed the title upload when clicking activity bar or open terminal Auto Upload / Download : Disable change detection for workspace storage folder. Dec 7, 2018
@shanalikhan shanalikhan added this to the Backlog milestone Dec 7, 2018
@tranhl
Copy link

tranhl commented Jan 15, 2019

Any updates on this bug? This is interfering with vscode-vim's status bar theming (as it overrides status bar styles using the workspace's settings.json) and preventing me from making a switch to vim.

@pltrant
Copy link

pltrant commented Feb 15, 2019

I also had this issue and had to disable the auto upload feature. Clicking the activity bar, which many extensions use, should not trigger an upload. This didn't start happening until VSC 1.31.

@shanalikhan shanalikhan modified the milestones: Backlog, v3.2.8 Mar 31, 2019
@shanalikhan
Copy link
Owner

Its fixed in new version. Please update and let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants