This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
fix: update osmosis min fee to comply with v15.0.0 min consensus fee update #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pastaghost
previously approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
gomesalexandre
previously approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untested but conceptually LGTM
kaladinlight
dismissed stale reviews from gomesalexandre and pastaghost
via
March 28, 2023 21:30
eb271d7
0xApotheosis
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conceptually solid, a few comments/questions.
shapeshift-ci-bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
# [@shapeshiftoss/chain-adapters-v11.2.1](https://github.com/shapeshift/lib/compare/@shapeshiftoss/chain-adapters-v11.2.0...@shapeshiftoss/chain-adapters-v11.2.1) (2023-03-28) ### Bug Fixes * update osmosis min fee to comply with v15.0.0 min consensus fee update ([#1227](#1227)) ([b89d78b](b89d78b))
🎉 This PR is included in version @shapeshiftoss/chain-adapters-v11.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
shapeshift-ci-bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
# [@shapeshiftoss/swapper-v17.6.1](https://github.com/shapeshift/lib/compare/@shapeshiftoss/swapper-v17.6.0...@shapeshiftoss/swapper-v17.6.1) (2023-03-28) ### Bug Fixes * update osmosis min fee to comply with v15.0.0 min consensus fee update ([#1227](#1227)) ([b89d78b](b89d78b))
🎉 This PR is included in version @shapeshiftoss/swapper-v17.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MIN_FEE
in osmosis swapperMIN_FEE
withcalcFee
+scalar
forgetFeeData