Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

fix: update osmosis min fee to comply with v15.0.0 min consensus fee update #1227

Merged
merged 3 commits into from
Mar 28, 2023

Conversation

kaladinlight
Copy link
Contributor

  • single const
  • use MIN_FEE in osmosis swapper
  • use MIN_FEE with calcFee + scalar for getFeeData

@kaladinlight kaladinlight requested a review from a team as a code owner March 28, 2023 18:48
pastaghost
pastaghost previously approved these changes Mar 28, 2023
Copy link
Collaborator

@pastaghost pastaghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gomesalexandre
gomesalexandre previously approved these changes Mar 28, 2023
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested but conceptually LGTM

Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually solid, a few comments/questions.

@kaladinlight kaladinlight merged commit b89d78b into main Mar 28, 2023
@kaladinlight kaladinlight deleted the osmo-swap-min-fee branch March 28, 2023 22:48
shapeshift-ci-bot pushed a commit that referenced this pull request Mar 28, 2023
# [@shapeshiftoss/chain-adapters-v11.2.1](https://github.com/shapeshift/lib/compare/@shapeshiftoss/chain-adapters-v11.2.0...@shapeshiftoss/chain-adapters-v11.2.1) (2023-03-28)

### Bug Fixes

* update osmosis min fee to comply with v15.0.0 min consensus fee update ([#1227](#1227)) ([b89d78b](b89d78b))
@shapeshift-ci-bot
Copy link
Member

🎉 This PR is included in version @shapeshiftoss/chain-adapters-v11.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

shapeshift-ci-bot pushed a commit that referenced this pull request Mar 28, 2023
# [@shapeshiftoss/swapper-v17.6.1](https://github.com/shapeshift/lib/compare/@shapeshiftoss/swapper-v17.6.0...@shapeshiftoss/swapper-v17.6.1) (2023-03-28)

### Bug Fixes

* update osmosis min fee to comply with v15.0.0 min consensus fee update ([#1227](#1227)) ([b89d78b](b89d78b))
@shapeshift-ci-bot
Copy link
Member

🎉 This PR is included in version @shapeshiftoss/swapper-v17.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants