This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
fix: keepkey swaps from RUNE #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use coinAsset as "THOR.RUNE" as defined in the thorchain swap protocol
0xApotheosis
reviewed
Apr 3, 2023
packages/chain-adapters/src/cosmossdk/thorchain/ThorchainChainAdapter.ts
Show resolved
Hide resolved
packages/chain-adapters/src/cosmossdk/thorchain/ThorchainChainAdapter.ts
Outdated
Show resolved
Hide resolved
packages/chain-adapters/src/cosmossdk/thorchain/ThorchainChainAdapter.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Regression tested while linked in web while manually applying this diff in the chain-adapters dist. This can't be tested by linking, nor installing built module as this check fails (this is an issue I've definitely seen previously):
Develop
Swap to RUNE
Swap from RUNE
- Doesn't go past the "Thorchain Account" step on the KK
This diff's chain-adapters "linked"
Swap to RUNE
Swap from RUNE
…inChainAdapter.ts
packages/chain-adapters/src/cosmossdk/thorchain/ThorchainChainAdapter.ts
Outdated
Show resolved
Hide resolved
packages/chain-adapters/src/cosmossdk/thorchain/ThorchainChainAdapter.ts
Show resolved
Hide resolved
…inChainAdapter.ts
gomesalexandre
approved these changes
Apr 4, 2023
shapeshift-ci-bot
pushed a commit
that referenced
this pull request
Apr 4, 2023
# [@shapeshiftoss/chain-adapters-v11.2.2](https://github.com/shapeshift/lib/compare/@shapeshiftoss/chain-adapters-v11.2.1...@shapeshiftoss/chain-adapters-v11.2.2) (2023-04-04) ### Bug Fixes * keepkey swaps from RUNE ([#1231](#1231)) ([eb889d6](eb889d6))
|
🎉 This PR is included in version @shapeshiftoss/chain-adapters-v11.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes swaps from RUNE when using a KeepKey.
Uses "THOR.RUNE" as a
thorchain/MsgDepositMsgType coin asset, as defined in the THORChain protocol:https://dev.thorchain.org/thorchain-dev/concepts/memos#asset-notation
The reason is hdwallet-keepkey has stronger validation, and the
runecoin asset we currently use doesn't pass validation there:https://github.com/shapeshift/hdwallet/blob/925de40aac9a2e3cafe09c5f33f5cc42417461bd/packages/hdwallet-keepkey/src/thorchain.ts#L96-L98
See the shape of a "valid" message (in
hdwallet-keepkeyterms) here: https://github.com/shapeshift/hdwallet/blob/925de40aac9a2e3cafe09c5f33f5cc42417461bd/integration/src/thorchain/tx01.mainnet.thorchain.swap.json#L15-L29Note that this is NOT a limitation of the network. This is actually an arbitrary check of
hdwallet-keepkey, and bothruneandTHOR.RUNEare actually valid variants in the Thorchain world, see: https://gitlab.com/thorchain/thornode/-/blob/622179d8bf966f7a14ea8074e521914461d521ce/common/asset_test.go#L31-33Unfortunately, confirmed by monkey-patching
hdwallet-keepkeyto allowruneinstead ofTHOR.RUNEthat KeepKey produces an invalid signature while using therunevariant, which seems to indicate a firmware arbitrary limitation.