This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
fix: isQuoteSellAmountBelowMinimum #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 10, 2023
gomesalexandre
approved these changes
Apr 10, 2023
There was a problem hiding this comment.
Tested against develop web with current lib version, both with the TradeRates flag on and off
With TradeRates on and manual CoW selection:
This lib diff
develop's lib, note the "Insufficient sell amount" which is indeed incorrect
With TradeRates off and monkey patched ZrxSwapperEthereum off in web
This lib diff
develops lib
I wasn't able to reproduce the sad behavior with the TradeRates flag off, though turning the TradeRates flag on confirmed adding back the CoW fees (i.e the fees taken from the sell asset and effectively occurring on the buy asset) for the minimum is now correct.
shapeshift-ci-bot
pushed a commit
that referenced
this pull request
Apr 10, 2023
# [@shapeshiftoss/swapper-v17.6.3](https://github.com/shapeshift/lib/compare/@shapeshiftoss/swapper-v17.6.2...@shapeshiftoss/swapper-v17.6.3) (2023-04-10) ### Bug Fixes * isQuoteSellAmountBelowMinimum ([#1235](#1235)) ([ac5f2c6](ac5f2c6))
|
🎉 This PR is included in version @shapeshiftoss/swapper-v17.6.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
gomesalexandre
added a commit
to shapeshift/web
that referenced
this pull request
Apr 10, 2023
Diff manually re-applied from shapeshift/lib#1235 after monorail
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing logic incorrectly assumes that the
sellAmountCryptoBaseUnitis the amount not including fees.In reality, CoW Swap subtracts any trading fees from the
sellAmountCryptoBaseUnitvalue in the returned response, so we need to add them back on to get the true "sell amount" of the sell asset.This is causing the UI to show that the "sell amount is lower than the fee" when the sell amount is above the minimum by less than the fee amount.
To test, attempt to use CoW swap to trade, say, $21 - this should now work, whereas previously is would not until you sold $20 plus the fee amount.