This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
feat: send max #262
Merged
feat: send max #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaoDev44
approved these changes
Dec 1, 2021
cjthompson
approved these changes
Dec 1, 2021
if (!erc20Balance) throw new Error('no balance') | ||
tx.value = erc20Balance | ||
} else { | ||
const fee = new BigNumber(gasPrice).times(gasLimit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential NaN issue
shapeshift-ci-bot
pushed a commit
that referenced
this pull request
Dec 2, 2021
# [@shapeshiftoss/types-v1.15.0](https://github.com/shapeshift/lib/compare/@shapeshiftoss/types-v1.14.0...@shapeshiftoss/types-v1.15.0) (2021-12-02) ### Features * send max ([#262](#262)) ([dab48ec](dab48ec))
🎉 This PR is included in version @shapeshiftoss/types-v1.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
shapeshift-ci-bot
pushed a commit
that referenced
this pull request
Dec 2, 2021
# [@shapeshiftoss/chain-adapters-v1.20.0](https://github.com/shapeshift/lib/compare/@shapeshiftoss/chain-adapters-v1.19.0...@shapeshiftoss/chain-adapters-v1.20.0) (2021-12-02) ### Features * send max ([#262](#262)) ([dab48ec](dab48ec))
🎉 This PR is included in version @shapeshiftoss/chain-adapters-v1.20.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
send max support for btc and eth.
#249