Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

feat: send max #262

Merged
merged 6 commits into from
Dec 2, 2021
Merged

feat: send max #262

merged 6 commits into from
Dec 2, 2021

Conversation

elmutt
Copy link
Collaborator

@elmutt elmutt commented Dec 1, 2021

send max support for btc and eth.

#249

@elmutt elmutt requested a review from a team as a code owner December 1, 2021 01:16
if (!erc20Balance) throw new Error('no balance')
tx.value = erc20Balance
} else {
const fee = new BigNumber(gasPrice).times(gasLimit)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential NaN issue

@elmutt elmutt merged commit dab48ec into main Dec 2, 2021
@elmutt elmutt deleted the send_max branch December 2, 2021 16:41
shapeshift-ci-bot pushed a commit that referenced this pull request Dec 2, 2021
@shapeshift-ci-bot
Copy link
Member

🎉 This PR is included in version @shapeshiftoss/types-v1.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@shapeshift-ci-bot
Copy link
Member

🎉 This PR is included in version @shapeshiftoss/chain-adapters-v1.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants