Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miner Fee trading out of FOX is $0.00 when entering a USD amount #4168

Closed
2 tasks done
MBMaria opened this issue Mar 30, 2023 · 2 comments · Fixed by shapeshift/lib#1230
Closed
2 tasks done

Miner Fee trading out of FOX is $0.00 when entering a USD amount #4168

MBMaria opened this issue Mar 30, 2023 · 2 comments · Fixed by shapeshift/lib#1230
Assignees
Labels
needs engineering Requires engineering input before bounty

Comments

@MBMaria
Copy link

MBMaria commented Mar 30, 2023

Overview

When doing a trade out of FOX, the miner fee is $0.00 if you select a USD amount to trade. Selecting an amount in the native token gives an amount for the miner fee.

References and additional details

  1. Log into app.shapeshift and connect to wallet of choice
  2. Use trade modal on dashboard or navigate to trade page
  3. Create a trade out of FOX, entering a USD amount
  4. Note that the miner fee is $0.00
  5. Select an amount to trade in fox token and note that a miner fee calculates
    image

Acceptance Criteria

Selecting USD amount should calculate miner fee

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • If my bounty needs engineering or needs product I have added the respective labels on the right
  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.
@MBMaria MBMaria added the needs engineering Requires engineering input before bounty label Mar 30, 2023
@MBMaria
Copy link
Author

MBMaria commented Mar 30, 2023

@0xApotheosis FYI

@gomesalexandre
Copy link
Contributor

@MBMaria Can you confirm this state happened with a ZRX or CoW swap? As noted by @0xApotheosis in https://discord.com/channels/554694662431178782/1091123238089785405/1091177027828191263, 0 fee for CoW swaps is actually correct, as there is a 0$ native asset fee i.e CoW fees are taken from your sell ERC20 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs engineering Requires engineering input before bounty
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants