Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syslog highlighting confused if there is no colon in message #1794

Closed
scop opened this issue Aug 11, 2021 · 3 comments · Fixed by #1800
Closed

syslog highlighting confused if there is no colon in message #1794

scop opened this issue Aug 11, 2021 · 3 comments · Fixed by #1800
Labels
bug Something isn't working syntax-highlighting

Comments

@scop
Copy link
Contributor

scop commented Aug 11, 2021

Describe the bug you encountered:

Syslog highlighter gets confused if a message without colon occurs. Highlighting "leaks" to the next line, gets likely terminated by the colon in the next line's timestamp, and works thereafter.

Example (on Ubuntu 20.04, rsyslog):

$ logger --server localhost hello
$ tail -n 1 /var/log/syslog
Aug 11 21:40:31 uncleman scop hello

Screenshot from 2021-08-11 21-45-01

What did you expect to happen instead?

No confusion, lines with messages without colons would work.

How did you install bat?

Current git master.

bat version and environment

@scop scop added the bug Something isn't working label Aug 11, 2021
@sharkdp
Copy link
Owner

sharkdp commented Aug 12, 2021

Thank you for reporting this.

It would be fantastic if @keith-hall could have a look into this (#1606 for context)

@keith-hall
Copy link
Collaborator

I believe this has been addressed with #1793 and thus this issue can be closed - please correct me if I'm wrong, @scop ? :)

@scop
Copy link
Contributor Author

scop commented Aug 16, 2021

Correcting :) #1793 addressed two different issues, this one's still open as reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working syntax-highlighting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants