Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kotlin support #215

Closed
nkiesel opened this issue Aug 23, 2018 · 5 comments
Closed

Add Kotlin support #215

nkiesel opened this issue Aug 23, 2018 · 5 comments
Labels
Milestone

Comments

@nkiesel
Copy link

nkiesel commented Aug 23, 2018

Could you please add support for highlighting Kotlin?

@sharkdp
Copy link
Owner

sharkdp commented Aug 23, 2018

Thank you for the feedback!

We can do this, yes. We will need a Sublime Text .sublime-syntax file for Kotlin.

See: https://github.com/sharkdp/bat/tree/master/assets#syntax-highlighting-in-bat

@nkiesel
Copy link
Author

nkiesel commented Aug 23, 2018

Would Kotlin.tmLanguage from https://github.com/vkostyukov/kotlin-sublime-package do the trick? Not a Sublime user myself (yet), so hard for me to tell.

@nkiesel
Copy link
Author

nkiesel commented Aug 23, 2018

Just a question, not a suggestion: why are you not using https://github.com/alecthomas/chroma ? That seems to support many more languages (incl. Kotlin) out of the box.

@sharkdp
Copy link
Owner

sharkdp commented Aug 23, 2018

Would Kotlin.tmLanguage from vkostyukov/kotlin-sublime-package do the trick? Not a Sublime user myself (yet), so hard for me to tell.

That should work, yes. It seems to be the only Kotline Sublime package out there.

We would have to convert to .sublime-syntax as described in the `assets/README.md´.

Just a question, not a suggestion: why are you not using alecthomas/chroma ? That seems to support many more languages (incl. Kotlin) out of the box.

bat is written in Rust, not Go.

@nkiesel
Copy link
Author

nkiesel commented Aug 23, 2018

Here is what I got after conversion. I asked a colleague for help and have no way to validate this.

Kotlin.zip

@sharkdp sharkdp added this to the v0.6.0 milestone Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants