Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOML support #37

Closed
mcginty opened this issue May 2, 2018 · 7 comments
Closed

TOML support #37

mcginty opened this issue May 2, 2018 · 7 comments
Assignees
Labels
Milestone

Comments

@mcginty
Copy link

mcginty commented May 2, 2018

Hey! Looks like TOML support is missing. Sorry if this issue should be on one of your dependencies and not this repo :).

I added it with the README's instruction for syntax support, but might be nice to include by default, especially since this tool is written in Rust!

@sharkdp
Copy link
Owner

sharkdp commented May 2, 2018

Sounds good! Could you please let me know which syntax file you used?

@mcginty
Copy link
Author

mcginty commented May 2, 2018

I chose https://github.com/lmno/TOML, which I converted to .sublime-syntax, but I spoke too soon because it's an incomplete version of the TOML spec. At this point I'm not sure if there's a good out-of-the-box choice for TOML. If I have free time I might try to fix it up, but it's going to be a busy few weeks :/.

@sharkdp
Copy link
Owner

sharkdp commented May 2, 2018

I found this: https://github.com/jasonwilliams/sublime_toml_highlighting (it is the one which is suggested first in Sublime Texts Package Control)

@mcginty
Copy link
Author

mcginty commented May 2, 2018

Oh nice, I just tried that out and it seems to highlight a more complex TOML file correctly.

@mcginty
Copy link
Author

mcginty commented May 2, 2018

https://gist.github.com/mcginty/168a500f3ff0cab7f096926ed3860a1f here's a converted version of that better definition.

@sharkdp
Copy link
Owner

sharkdp commented May 2, 2018

There is also this: jasonwilliams/sublime_toml_highlighting#7 😄

@mcginty
Copy link
Author

mcginty commented May 2, 2018

oh that's awesome, glad other people are so on top of this haha

@sharkdp sharkdp self-assigned this May 6, 2018
@sharkdp sharkdp added this to the 0.3 milestone May 6, 2018
@sharkdp sharkdp closed this as completed in 23d92d7 May 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants