Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please publish Cargo.lock with the crate #16

Closed
polyzen opened this issue Nov 5, 2018 · 7 comments
Closed

Please publish Cargo.lock with the crate #16

polyzen opened this issue Nov 5, 2018 · 7 comments

Comments

@polyzen
Copy link
Contributor

polyzen commented Nov 5, 2018

error: the lock file needs to be updated but --locked was passed to prevent this

@sharkdp
Copy link
Owner

sharkdp commented Nov 5, 2018

What exactly do you mean? The Cargo.lock file seems to be up-to-date, i.e. it does not change if I run cargo build.

@polyzen
Copy link
Contributor Author

polyzen commented Nov 5, 2018

I see the lock file isn't shipped with the crate.

Looks like this would be needed:
rust-lang/cargo#5654

@polyzen polyzen changed the title Please update lock file Please publish Cargo.lock with the crate Nov 5, 2018
@polyzen
Copy link
Contributor Author

polyzen commented Nov 5, 2018

What do you think? I requested this from a bunch of projects (for reproducible builds) before realizing it was a bit more involved.

@sharkdp
Copy link
Owner

sharkdp commented Nov 6, 2018

Sounds like a good idea to me, thank you. Let's add this.

@sharkdp
Copy link
Owner

sharkdp commented Nov 21, 2018

Closing this for now, see #17

@sharkdp sharkdp closed this as completed Nov 21, 2018
@polyzen
Copy link
Contributor Author

polyzen commented Jun 3, 2019

@sharkdp
Copy link
Owner

sharkdp commented Jun 3, 2019

Thank you for the info. Happy to release a new version once this is implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants