Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basedata import - multiple files go into separate basedatas #378

Closed
GoogleCodeExporter opened this issue Mar 27, 2015 · 18 comments
Closed

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. multiple datasets option used on import base data function

What is the expected output? 
multiple imported files

What do you see instead?
single appended file 

What version of the product are you using? On what operating system?
BiodiverseGUI_x64_dev_0.18_005.exe

Please provide any additional information below.
I’m preparing multiple biological groups for site-pair sampling and importing 
them into biodiverse to generate the *.bds dataset needed.

I tried the import multiple datasets thinking that it would produce separate 
inputs but I think this resulted in appended inputs. That’s useful too, in 
certain situations. 

I wondered if it might be possible to make the append an option when multiple 
base datasets are imported?

This saves lots of navigating and importing of individual datasets that are 
setup identically 

Original issue reported on code.google.com by Kristen....@csiro.au on 25 Apr 2013 at 9:08

@GoogleCodeExporter
Copy link
Author

This would be a useful feature.  

I will aim to add it to the next+1 release version (which is likely to be 
version 1).

In the interim it can be implemented using a script, iterating over a set of 
input files and importing each one in turn.  

If I get a chance I'll add such a script to the example_scripts directory.  

Shawn.

Original comment by shawnlaffan on 25 Apr 2013 at 10:28

  • Changed state: Accepted
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Set type to enhancement.

Original comment by shawnlaffan on 26 Apr 2013 at 11:18

  • Added labels: Type-Enhancement
  • Removed labels: Type-Defect

@GoogleCodeExporter
Copy link
Author

Add to the 1.0 list of features.  

Original comment by shawnlaffan on 14 Nov 2013 at 4:24

  • Added labels: Milestone-Release1.0
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Assign to Anthony.  

Original comment by shawnlaffan on 27 Feb 2014 at 5:03

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

This issue was updated by revision r2275.


Modified GUI to handle identifying multiple import option.  further 
modification to import / run routines to create and initialise new basedatas 
appropriately

Original comment by anthony....@gmail.com on 4 Apr 2014 at 9:08

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Change issue title to reflect its aim. 
Set status to started.  

Original comment by shawnlaffan on 6 Apr 2014 at 5:45

  • Changed title: Basedata import - multiple files go into separate basedatas
  • Changed state: Started
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

This issue was updated by revision r2282.

Change the flag variable and widget names for one basedata per imported file so 
it matches its purpose more closely.  Move its call up in the file as dlgxml 
has changed by the time it was being called, so the widget no longer existed.  
The mutable $dlgxml aspect of the code needs to be changed methinks, as it is 
confusing.  
Make sure we use array refs when setting cell size and origin parameters.  
Clear out the swapped="no" calls from the glade file.  These will no doubt 
creep back in due to the glade editor so constant vigilance is needed.  perhaps 
a test should be added, and maybe a commit hook to remove them.

Next is to make sure we add all the files.  Iterating over a list is perhaps 
the simplest approach since the arguments are the same except the file names.  
In the single file case it can just be a single item list, or we can pass an 
array ref as the first list item when we want to lump the files into one 
basedata.

Original comment by shawnlaffan on 6 Apr 2014 at 6:22

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

This issue was updated by revision r2283.

Missed one variable call in the last set of changes.  

Original comment by shawnlaffan on 6 Apr 2014 at 6:25

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

This issue was updated by revision r2284.

Make sure we deref the cell size and origin arrays from the reorder dialog.  
Otherwise we pass on an array comprising a single array ref, and this breaks 
things lower down.  

Original comment by shawnlaffan on 6 Apr 2014 at 6:34

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

This issue was updated by revision r2290.


Including methods to import multiple datasets as separate new basedatas

Original comment by anthony....@gmail.com on 8 Apr 2014 at 5:14

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

This issue was updated by revision r2291.


Changed handling in basedata import so uses common set of basedata & filename 
mappings, to simplify code.  Need to change interface & import routine to 
handle some more subtleties of importing multiple files, eg importing set and 
finding existing basedata with given name

Original comment by anthony....@gmail.com on 8 Apr 2014 at 6:27

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

This issue was updated by revision r2367.


Modified import to allow import of multiple files, with the option of loading 
as new datasets, or searching for existing basedatas with the same name 
(determined from file), and adding to the existing dataset.

Operation is controlled by the "Multiple as separate.." and "new" checkboxes on 
import.  If multiple and new chosen, new separate BDs are created, even if 
existing are present.  If multiple chosen and not new, for each imported file 
it will search for an existing BD with the same name, and add to it, however if 
an existing is not found, a new one will be created.

Original comment by anthony....@gmail.com on 30 Apr 2014 at 4:36

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

This issue was updated by revision r2371.

Clean up some tabs, a little minor refactoring for brevity.

Original comment by shawnlaffan on 3 May 2014 at 4:07

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

This issue was updated by revision r2372.

Update the tooltip for the multiple file import checkbox, and change the 
associated label text
More whitespace cleanup, plus a few stylistic changes.

Original comment by shawnlaffan on 3 May 2014 at 5:11

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

This issue was updated by revision r2375.

Merge revisions across to the trunk. 

Original comment by shawnlaffan on 3 May 2014 at 7:36

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

This issue was updated by revision r2390.

Importation of new data into an existing basedata was not working due to recent 
changes in the multiple file imports.  The code just hadn't been updated.  
t/11-BaseData.t:  Add tests for importation of zero sample count data.  
Grid.pm:  minor cleanup.

Original comment by shawnlaffan on 13 May 2014 at 2:42

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

This issue was updated by revision r2425.

Delete branch

Original comment by shawnlaffan on 30 May 2014 at 5:15

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Mark as fixed.
ANy future changes can be listed under their own issues.  

Original comment by shawnlaffan on 30 May 2014 at 5:16

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

@shawnlaffan shawnlaffan modified the milestone: Release1.0 Apr 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants