Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cursor after clicking the zoom in or zoom out tool #490

Closed
GoogleCodeExporter opened this issue Mar 27, 2015 · 14 comments
Closed

Change cursor after clicking the zoom in or zoom out tool #490

GoogleCodeExporter opened this issue Mar 27, 2015 · 14 comments

Comments

@GoogleCodeExporter
Copy link

Suggestion that after clicking the zoom in or zoom out tool, the cursor changes 
to match the zoom in or zoom out icon. It would remain like that until a 
different function is chosen.

At present after clicking zoom in, the symbol is a) an arrow when pointing to 
empty areas, b) a finger when pointing to groups and c) a 4 point arrow when 
pointing to drag the zoom-square.

Original issue reported on code.google.com by danielrosauer on 14 Aug 2014 at 5:49

@GoogleCodeExporter
Copy link
Author

Original comment by shawnlaffan on 14 Aug 2014 at 6:14

  • Changed state: Accepted
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Original comment by shawnlaffan on 14 Aug 2014 at 6:14

@GoogleCodeExporter
Copy link
Author

Add issue 353 as a blocker

Original comment by shawnlaffan on 20 Aug 2014 at 10:25

@GoogleCodeExporter
Copy link
Author

Original comment by shawnlaffan on 20 Aug 2014 at 10:25

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Add 1.0 milestone.

Original comment by shawnlaffan on 20 Aug 2014 at 10:27

  • Added labels: Milestone-Release1.0
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

This issue was updated by revision r2730.

Cursors now match the current behaviour, so zoom in, zoom out, pan etc.  This 
is more intuitive.
Refactor more of the handlers into Tab.pm to avoid duplication. 
(also update issue 353)

Original comment by shawnlaffan on 23 Aug 2014 at 11:27

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

This issue was updated by revision r2732.

Change the cursor to the hand when we are in select mode and hovering over a 
cell or branch.  This is the old (existing, really) behaviour.

Original comment by shawnlaffan on 23 Aug 2014 at 10:40

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

This issue was updated by revision r2734.

Avoid gtk faults by not setting display cursors when a canvas has yet to be 
properly initialised.  This happens when the mouse hovers over a pane during 
initialisation.  

Original comment by shawnlaffan on 23 Aug 2014 at 11:09

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Original comment by shawnlaffan on 26 Aug 2014 at 5:50

@GoogleCodeExporter
Copy link
Author

Original comment by shawnlaffan on 26 Aug 2014 at 5:52

  • Changed state: Started
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Remaining tasks on this issue are to generate the cursors once and cache them.  
Currently we reload the icons from disk each time, and this will have lag 
effects when running over a network. 

Original comment by shawnlaffan on 5 Sep 2014 at 12:25

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

This issue was updated by revision r2764.

Cache the pan and zoom /in|out|full/ cursors after first use in each display 
tab.  This should reduce some performance lags when running over networks.  
Add cache methods to Tab.pm to do this.  These are copied directly from 
Biodiverse::Common, but we don;t want to depend on all of Biodiverse::Common at 
this stage (is this really a bad thing?).

Original comment by shawnlaffan on 6 Sep 2014 at 4:06

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Mark as fixed.  

Original comment by shawnlaffan on 6 Sep 2014 at 4:07

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

This issue was updated by revision r2765.

Merge final revisions across to the trunk.  
(Should have done this before marking as fixed).

Original comment by shawnlaffan on 6 Sep 2014 at 5:27

  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants