Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Labels - crash when trimming all nodes in a displayed tree #534

Closed
GoogleCodeExporter opened this issue Mar 27, 2015 · 3 comments
Closed

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1.  Trim a tree to match the basedata, but where no branches match so all will 
be deleted

What is the expected output? What do you see instead?
It should display nothing, instead it crashes.  

This is possibly caused by the labels_group not being updated, but a 
work-around is to not centre the tree when the sum of branch lengths is zero.  


Original issue reported on code.google.com by shawnlaffan on 3 Dec 2014 at 4:26

@GoogleCodeExporter
Copy link
Author

Original comment by shawnlaffan on 3 Dec 2014 at 4:26

  • Changed title: View Labels - crash when trimming all nodes in a displayed tree
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

This issue was updated by revision r3096.

Avoid recentring the tree when there is not length to display.  
A better fix might be to clear the lines_group.

Original comment by shawnlaffan on 3 Dec 2014 at 4:27

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Mark as fixed

Original comment by shawnlaffan on 3 Dec 2014 at 5:36

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

@shawnlaffan shawnlaffan modified the milestone: Release1.0 Apr 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants