Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support environment variables for plantuml location #1826

Closed
NovarisOberion opened this issue Oct 10, 2023 · 8 comments
Closed
Assignees

Comments

@NovarisOberion
Copy link

Is your feature request related to a problem? Please describe.
I am using a relative path to plantuml based on an environmental variable (e.g. set PUML = C:<path>\plantuml.jar.
Now I wanted to write in my config.json "${env:PUML}" to tell markdown-preview-enhanced to use the path provided in the environment variable PUML but unfortunately it does not work that way.

Describe the solution you'd like
Either allow plantuml.jar to be part of the PATH or allow the usage of VSCode's environmental variable syntax.

Describe alternatives you've considered
I tried to put the folder on the PATH but it did not work either.

@NovarisOberion
Copy link
Author

@NovarisOberion
Copy link
Author

Nebermind, seems "${env:PUML}\plantuml.jar" seems to work :D

@NovarisOberion NovarisOberion changed the title [Feature Request] [Feature Request] Support environment variables for plantuml location Oct 10, 2023
@NovarisOberion
Copy link
Author

Seems it was an artifact, it does not work :(

@shd101wyy
Copy link
Owner

Will support in next release 👍

@NovarisOberion
Copy link
Author

Thanks! 👍

@shd101wyy
Copy link
Owner

Should be supported now

@NovarisOberion
Copy link
Author

Will give it a try

@NovarisOberion
Copy link
Author

Indeed! Many thanks for the quick update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants