Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit bb3de8fa5e509d5f5faf173fd1a92635a0023274 breaks html script indent #643

Closed
jacobmischka opened this issue Dec 2, 2020 · 5 comments

Comments

@jacobmischka
Copy link

jacobmischka commented Dec 2, 2020

Does this bug happen when you install plugin without vim-polyglot?

N/A

Describe the bug:

Script tag indentation is broken.

To Reproduce:

Update to a commit after bb3de8f (including the most recent commit in master), attempt editing JavaScript in a <script> tag

bb3de8f:
broken

b3763a9: (Highlighting is broken in the commit, but indentation works)
broken differently

As a workaround, I'm currently using 5bd9f16, which has working indentation and highlighting for my uses.

I'm using neovim v0.4.4.

@kbwo
Copy link

kbwo commented Dec 3, 2020

I'm facing with same issue using vim v8.2 and neovim v0.5.0

@sheerun
Copy link
Owner

sheerun commented Dec 29, 2020

This seems to be issue with pangloss/vim-javascript, not vim-polyglot. I'll move this issue there

@sheerun
Copy link
Owner

sheerun commented Dec 29, 2020

Please let me know if you'll find workaround, then I can maybe patch it here pangloss/vim-javascript#1226

@sheerun sheerun closed this as completed Dec 29, 2020
@jacobmischka
Copy link
Author

After forgetting about this for a while, I just updated vim-polyglot and it seems to be fine now. So whatever the issue was, it looks to be fixed.

@jacobmischka
Copy link
Author

jacobmischka commented Mar 29, 2021

Ah sorry, it's actually still an issue, I was mistaken.

I actually don't think this is an issue with vim-javascript, because the commit that broke it in this repository was touching a lot of html files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants