Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript typings incompatible with webpack 5. #279

Closed
wegry opened this issue Nov 18, 2021 · 10 comments
Closed

Typescript typings incompatible with webpack 5. #279

wegry opened this issue Nov 18, 2021 · 10 comments

Comments

@wegry
Copy link

wegry commented Nov 18, 2021

  • Manifest Plugin Version: 4.0.2
  • Webpack Version: 5.64.1
  • Operating System (or Browser): macOS
  • Node Version: 16.13.0
  • Link to reproduction (⚠️ read below):

https://github.com/wegry/webpack-5typescript-types-breaking-webpack-manifest-plugin/tree/main

Expected Behavior

webpack-manifest-plugin should compile with tsc with webpack@5.

Actual Behavior

webpack-manifest-plugin seems to be using webpack 4 typings instead.

Additional Information

Originally I ran into this issue in yarn 3 with nodeLinker: node-modules. The repro repo is yarn 1 though.

@shellscape
Copy link
Owner

Yeah I doubt we'll be able to resolve that until we drop Webpack v4 support.

@SunHuawei
Copy link
Contributor

I'm experiencing the same issue. So, is there any plan?

@shellscape
Copy link
Owner

@SunHuawei did you read my last reply?

@SunHuawei
Copy link
Contributor

@shellscape , yes, I did. I mean is there a plan to drop v4 support? I know that's not easy for the existing user, however, due to that it's a breaking change, is that possible to just upgrade to v5 for this plugin to support webpack@5. That would be perfect for both v4 and v5 users.

@shellscape
Copy link
Owner

I don't currently have the motivation to make that change.

@SunHuawei
Copy link
Contributor

I don't get it, do you mean you don't see any value in it? Or, you're too busy? Honestly, I love this project, and I need it very much. If you can help review and merge, I can spend some time doing that upgrade. What do you think?

@shellscape
Copy link
Owner

community contribution is always welcome

@stale
Copy link

stale bot commented Feb 18, 2022

Hey folks. This issue hasn't received any traction for 60 days, so we're going to close this for housekeeping. If this is still an ongoing issue, please do consider contributing a Pull Request to resolve it. Further discussion is always welcome even with the issue closed. If anything actionable is posted in the comments, we'll consider reopening it.

@SunHuawei
Copy link
Contributor

I've submitted a PR here #289.

@shellscape
Copy link
Owner

Closed in #289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants