Correctly handle spaces in executable (python-poetry#1774)

shenek · Dec 31, 2019 · af28d22 · af28d22
1 parent 8da21ce
commit af28d22
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/poetry/utils/env.py b/poetry/utils/env.py
@@ -190,7 +190,7 @@ def activate(self, python, io):  # type: (str, IO) -> Env
         try:
             python_version = decode(
                 subprocess.check_output(
-                    " ".join(
+                    list_to_shell_command(
                         [
                             python,
                             "-c",
@@ -427,7 +427,7 @@ def remove(self, python):  # type: (str) -> Env
         try:
             python_version = decode(
                 subprocess.check_output(
-                    " ".join(
+                    list_to_shell_command(
                         [
                             python,
                             "-c",
@@ -496,7 +496,7 @@ def create_venv(
         if executable:
             python_patch = decode(
                 subprocess.check_output(
-                    " ".join(
+                    list_to_shell_command(
                         [
                             executable,
                             "-c",
@@ -553,7 +553,7 @@ def create_venv(
                 try:
                     python_patch = decode(
                         subprocess.check_output(
-                            " ".join(
+                            list_to_shell_command(
                                 [
                                     python,
                                     "-c",
@@ -638,7 +638,9 @@ def build_venv(cls, path, executable=None):
             # Create virtualenv by using an external executable
             try:
                 p = subprocess.Popen(
-                    " ".join([executable, "-"]), stdin=subprocess.PIPE, shell=True
+                    list_to_shell_command([executable, "-"]),
+                    stdin=subprocess.PIPE,
+                    shell=True,
                 )
                 p.communicate(encode(CREATE_VENV_COMMAND.format(path)))
             except CalledProcessError as e: