Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tours fail to load on Chrome 65 #180

Closed
robotmonkey opened this issue Mar 20, 2018 · 10 comments
Closed

Tours fail to load on Chrome 65 #180

robotmonkey opened this issue Mar 20, 2018 · 10 comments
Labels

Comments

@robotmonkey
Copy link

robotmonkey commented Mar 20, 2018

As per the screenshot below, tours are failing to load on Chrome 65 for many users. Only a sliver of the tour is loaded.

We believe there are compatibility issues with the latest Chrome (v65). It is currently working for us across all other browsers.

Tours

@jdmdigital
Copy link

I've only seen this behavior on Chrome on a Mac. Seems to work fine in the latest version of Chrome on a PC (v66).

@tihomir-kit
Copy link

tihomir-kit commented Jun 5, 2018

This could potentially have something to do with hardware acceleration on Macs:

https://bugs.chromium.org/p/chromium/issues/detail?id=794819
https://productforums.google.com/forum/#!topic/chrome/MofzGUnPbU0

Or not - since it's not the whole site that looks shattered but just a small bit.

PS - for us this also only occurs on new Macs..

@lozjackson
Copy link

We have come across this bug also..

It is on a macbook pro 15" mid-2015 with dual gfx cards.

The problem only occurs when using the Intel Iris Pro gfx card (built-in).. and the problem disappears upon switching to the AMD Radeon gfx (Automatic gfx switching in display preferences disable).

Chrome 67
Macbook Pro
Intel Iris Pro (built-in) / AMD Radeon (PCIe) gfx cards

If I inspect the element and untick the transform: translateZ(0); property, then the problem disappears...

@lozjackson
Copy link

I have tried this on other Macbook Pros.. without dual gfx cards and none have suffered the same problem yet. I have tried one other MBP with dual gfx cards, but not the same Intel Iris Pro card (it has an Intel HD Pro instead), and that also does not suffer the same problem.

I have not yet been able to find another MBP with the same Intel Iris Pro gfx card to test on.

@RobbieTheWagner
Copy link
Member

Hi @lozjackson could you try with 2.0.0-beta.2 that I just released? It's based around popper now, and might change things.

@RobbieTheWagner
Copy link
Member

I removed translateZ, since we don't need hardware acceleration, that I know of. Does anyone know of a reason it should not be removed?

@lozjackson
Copy link

lozjackson commented Aug 13, 2018

@rwwagner90 Thanks. I've just got round to updating ember-shepherd to 3.3.0.

The problem was not resolved after updating ember-shepherd... however, then we updated Chrome to the latest version (68.0.3440.106) and that fixed it.. (previously was using 67.0.3396.99)

I tested the previous version of ember-shepherd that we were running (3.1.0) and that also works ok using the new version of Chrome.

@RobbieTheWagner
Copy link
Member

@lozjackson ember-shepherd has beta versions for 4.0.0, which you can try. The tests don't all pass for them, but they should work I think.

@lozjackson
Copy link

@rwwagner90 Having updated the version of Chrome we would be unable to repro the issue now that it is fixed in Chrome. We only had one laptop here that was affected by this bug (and that has now been updated to the latest version of Chrome).

Also I would prefer not to run a beta version of ember-shepherd.. I appreciate that you would like to have the beta tested etc, however, our app is in production and I'm not in the habit of running beta or early "major-version" updates in production apps.. sorry.

@RobbieTheWagner
Copy link
Member

@lozjackson I was not suggesting that you run it in production. Just letting you know that ember-shepherd 4.0.0 beta is using the new stuff we've been working on here. Any pre 4.0 versions do not have any of the changes here and would most certainly still have the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants