Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide buttons if none are passed to Step.options.buttons #243

Closed
BrianSipple opened this issue Sep 9, 2018 · 0 comments · Fixed by #271
Closed

Hide buttons if none are passed to Step.options.buttons #243

BrianSipple opened this issue Sep 9, 2018 · 0 comments · Fixed by #271
Assignees
@BrianSipple
Labels
enhancement

Comments

@BrianSipple
Copy link
Contributor

BrianSipple commented Sep 9, 2018 •
edited
Loading

Currently, someone can only hide buttons by passing false to Step.options.buttons.

After more discussion about this, we decided that it would make for a much clearer interface if buttons were always hidden unless a non-empty array (each item being a set of button options) was passed.

cc @rwwagner90 @chuckcarpenter
@BrianSipple BrianSipple self-assigned this Sep 9, 2018
BrianSipple added a commit that referenced this issue Oct 12, 2018
@BrianSipple
Constrain input for Step.options.buttons to an array of buttons.
4c0bc24 
Closes [#243](#243).
@BrianSipple BrianSipple mentioned this issue Oct 12, 2018
Merged
BrianSipple added a commit that referenced this issue Oct 12, 2018
@BrianSipple
Constrain input for Step.options.buttons to an array of buttons.
a641253 
Closes [#243](#243).
BrianSipple added a commit that referenced this issue Oct 12, 2018
@BrianSipple
Constrain input for Step.options.buttons to an array of buttons.
8ba716a 
Closes [#243](#243).
BrianSipple added a commit that referenced this issue Oct 12, 2018
@BrianSipple
Constrain input for Step.options.buttons to an array of buttons.
6ff644f 
Closes [#243](#243).
RobbieTheWagner pushed a commit that referenced this issue Oct 12, 2018
@BrianSipple @RobbieTheWagner
Constrain input for Step.options.buttons to an array of buttons. (#271
aa1a8bc 
)

* Remove flakiness from buttons acceptance test

* add script for viewing test coverage

* Constrain input for `Step.options.buttons` to an array of buttons.

Closes [#243](#243).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrianSipple BrianSipple

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Constrain input for Step.options.buttons to an array of buttons. shipshapecode/shepherd
1 participant
@BrianSipple