Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object.assign not transpiled #323

Closed
jinhucheung opened this issue Jan 16, 2019 · 7 comments
Closed

Object.assign not transpiled #323

jinhucheung opened this issue Jan 16, 2019 · 7 comments
Labels

Comments

@jinhucheung
Copy link

Hello Shepherd,

Thanks for your AMAZING github Project. I posted a project that it wraps the Shepherd v2.1.0 for ruby on rails.

I noticed that call Object.assign without Babel polyfill, such as shepherd.js#L10

My app needs to be compatible with lower version browsers (IE11, chorme 44) on production

I hope the Shepherd can add Object.assign polyfill

Thanks a lot
JimCheung

@RobbieTheWagner
Copy link
Member

@jinhucheung what files are you using? The files are run through babel and outputted to dist.

@jinhucheung
Copy link
Author

jinhucheung commented Jan 16, 2019

@rwwagner90 I get js and css files from dist. They are in the assets

@RobbieTheWagner
Copy link
Member

@jinhucheung I suppose we do need to ensure IE compatibility. We have it in our browserslist, but I suppose we need to do more.

@RobbieTheWagner
Copy link
Member

@jinhucheung to the best of your knowledge is Object.assign the only unsupported thing we have in our dist? If so, I think I have a fix and I opened a PR for it.

@RobbieTheWagner RobbieTheWagner changed the title Object.assign polyfill Object.assign not transpiled Jan 16, 2019
@jinhucheung
Copy link
Author

@rwwagner90 Excellent, thank you!

@RobbieTheWagner
Copy link
Member

@jinhucheung I released 2.3.2, which should included the fix. Please give it a try!

@jinhucheung
Copy link
Author

@rwwagner90 yes, no problem in IE11 or chrome44 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants