Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong type definition for scrollTo #490

Closed
moxival opened this issue Aug 8, 2019 · 2 comments · Fixed by #494
Closed

Wrong type definition for scrollTo #490

moxival opened this issue Aug 8, 2019 · 2 comments · Fixed by #494
Labels
enhancement

Comments

@moxival
Copy link
Contributor

moxival commented Aug 8, 2019

Hi,

the type definition for scrollTo is wrong: https://github.com/shipshapecode/shepherd/blob/master/src/types/step.d.ts#L118

It is defined as boolean, but in reality it accepts { behavior: string, block?: string }|boolean
@RobbieTheWagner
Copy link
Member

Hi @moxival thanks for letting us know! Would you want to open a PR to fix it?

@moxival
Copy link
Contributor Author

moxival commented Aug 9, 2019

Hi @rwwagner90 please check PR #494

@moxival moxival mentioned this issue Aug 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for the wrong type definition of StepOptions.scrollTo moxival/shepherd
2 participants
@moxival @RobbieTheWagner