Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply scroll listener to all scroll events #322

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Apply scroll listener to all scroll events #322

merged 1 commit into from
Jan 16, 2019

Conversation

RobbieTheWagner
Copy link
Member

Fixes #319

chuckcarpenter
chuckcarpenter approved these changes Jan 16, 2019
View reviewed changes
Copy link
Member

@chuckcarpenter chuckcarpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and LGTM

@RobbieTheWagner RobbieTheWagner merged commit 011c236 into master Jan 16, 2019
@RobbieTheWagner RobbieTheWagner deleted the scroll-trigger branch January 16, 2019 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuckcarpenter chuckcarpenter chuckcarpenter approved these changes

@BrianSipple BrianSipple Awaiting requested review from BrianSipple

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobbieTheWagner @chuckcarpenter