Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove addStepEventListeners call #396

Merged
merged 1 commit into from
Jun 12, 2019
Merged

Conversation

RobbieTheWagner
Copy link
Member

@RobbieTheWagner RobbieTheWagner commented Jun 10, 2019

I am not 100% sure if removing this is okay or not. @chuckcarpenter do you know why we had this call here? Is addStepEventListeners only necessary when using modal mode?

Fixes #393

I am not 100% sure if removing this is okay or not. @chuckcarpenter do you know why we had this call here?
@chuckcarpenter
Copy link
Member

Looks like this is just a port of the Ember add-on, so not sure otherwise: f1c4eeb

@RobbieTheWagner
Copy link
Member Author

@chuckcarpenter addStepEventListeners is still called here

addStepEventListeners.call(this);

I think this extra call was maybe to ensure some of the touchmove stuff was setup immediately or something? If you can't see anything in addStepEventListeners that we need to run in the tour constructor, I say we remove it.

@chuckcarpenter
Copy link
Member

From my local testing in iOS and the docs site, this seems to work.

@RobbieTheWagner RobbieTheWagner merged commit 2d55d9a into master Jun 12, 2019
@RobbieTheWagner RobbieTheWagner deleted the remove-add-listeners branch June 12, 2019 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"TypeError: Property 'handleEvent' is not callable." in Firefox
2 participants