Add includeStyles option #526
Conversation
This will allow users who find themselves overriding a lot of styles to opt out of our base styles. Closes #497
|
@knoobie @chadarsenault does this approach work for you guys? It basically removes most of the styles if you set |
| /** | ||
| * Extra [options to pass to tippy.js]{@link https://atomiks.github.io/tippyjs/#all-options} | ||
| */ | ||
| tippyOptions?: object; |
There was a problem hiding this comment.
I like the alphabetizing
|
Thank you! The idea looks good! Have to find proper time to test it. (sorry) Proposal / idea for future improvement (dunno how much work that would be) - instead of one boolean: styling: {
header: true,
footer: true,
modal: true,
button: true,
content: true,
text: true
} |
|
@knoobie I don't think we should make it that granular. If you want to override a couple things we provide the variables to change the styles or overriding via CSS is always an option. |
|
To avoid wasting time as I did, note this isn't part of 9.1 release. Look at the source in master will show the includeStyles option is missing. Some error in the merge I think |
|
@msteel9999 this was intentionally removed. Since the styles live in a CSS file now, which you must manually include, if you don't want the styles at all, you can simply not include that file. |
|
@rwwagner90 has this option been removed ? It is not documented anywhere, but in the changelogs there is only a line saying it has been added... Is there a way to disable the |
|
@iPurpl3x the CSS is entirely optional. If you don't include it, the styles won't be there. |
|
Well yes, but I cannot selectively include CSS, like I would need all the layout CSS, but no colors etc... Anyway, I have now overridden the part that was conflicting with my button styling, so it's ok... |
This will allow users who find themselves overriding a lot of styles to opt out of our base styles. Closes #497