Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require attachTo.on to show arrow #979

Merged
merged 1 commit into from
May 18, 2020
Merged

Require attachTo.on to show arrow #979

merged 1 commit into from
May 18, 2020

Conversation

RobbieTheWagner
Copy link
Member

@RobbieTheWagner RobbieTheWagner commented May 18, 2020 •
edited
Loading

According to the docs, we should be hiding the arrow if you do not define attachTo.on so this should fix that issue.

Fixes #978

@RobbieTheWagner RobbieTheWagner mentioned this pull request May 18, 2020
Closed
chuckcarpenter
chuckcarpenter approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@chuckcarpenter chuckcarpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chuckcarpenter chuckcarpenter merged commit 7551ae5 into master May 18, 2020
@chuckcarpenter chuckcarpenter deleted the rwwagner90-patch-1 branch May 18, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuckcarpenter chuckcarpenter chuckcarpenter approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong behavior when not providing "on" value for "attachTo" for the second element
2 participants
@RobbieTheWagner @chuckcarpenter