error rendering values as a result of a string function. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…his test.
TypeError: Cannot assign to read only property 'eval' of monica
It happens on references.js, in the getPropMethod. Line 273, when trying to set baseRef.eval property.
|
The integration test running version v2.5.0 also reproduces the issue. |
…ejs enforces this by causing any attribution to fail. By limiting the changes to eval only to object types we avoid the problem.
|
Thank for you pr. That evel method is for rerender something, such as you can define the |
| baseRef.eval = function() { | ||
| return that.eval.apply(that, arguments); | ||
| }; | ||
| if(typeof baseRef === 'object'){ |
There was a problem hiding this comment.
If baseRef equal null, this will throw error too.
There was a problem hiding this comment.
Good catch!
If you want to be efficient, you might check for falsy values before calling typeof. That way, if baseRef is falsy a typeof evaluation is not necessary, as objects are always truthy.
if (baseRef && typeof baseRef === 'object') {
|
👍 The other problem of |
shepherdwind
added a commit
that referenced
this pull request
Oct 28, 2015
error rendering values as a result of a string function.
|
0.7.2 published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we define as vm that assigns the result of a string function, the render method fails stating this error:
This happens on references.js, in the getPropMethod. Line 273, when trying to set baseRef.eval property.
This test case highlights the issue.
Other information
node versions I see the issue present itself:
v4.2.1
v3.3.0
It does not seem to happen with node version 0.10.25. Maybe it's a bit more lax regarding this kind of attribution?
Maybe this pull request can help fix the code. I'll take a look at it as well, but I imagine you guys would know best.