Skip to content
This repository has been archived by the owner on Oct 1, 2023. It is now read-only.

Ch_301 - Missing validations for return value of oracle data feed #374

Closed
sherlock-admin opened this issue Mar 27, 2023 · 0 comments
Closed

Ch_301 - Missing validations for return value of oracle data feed #374

sherlock-admin opened this issue Mar 27, 2023 · 0 comments
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Medium A valid Medium severity issue Reward A payout will be made for this issue

Comments

@sherlock-admin
Copy link
Contributor

sherlock-admin commented Mar 27, 2023 •
edited by github-actions bot
Loading

Ch_301

medium

Missing validations for return value of oracle data feed

Summary

Vulnerability Detail

on getLatestPrice() the price feed must be checked if the data is really updated or not.

Impact

If the oracle price feeds are insufficiently validated, there will be pricing errors leading to wrong de-peg event or missing it

Code Snippet

Tool used

Manual Review

Recommendation

you should Add this check
require(updatedAt > 0, "error message");

Duplicate of #70
@github-actions github-actions bot closed this as completed Apr 3, 2023
@github-actions github-actions bot added Medium A valid Medium severity issue Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label labels Apr 3, 2023
@sherlock-admin sherlock-admin added the Reward A payout will be made for this issue label Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Medium A valid Medium severity issue Reward A payout will be made for this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sherlock-admin