Skip to content
This repository has been archived by the owner on Oct 1, 2023. It is now read-only.

bulej93 - mintDepositInQueue doesnt charge deposit fee #99

Closed
sherlock-admin opened this issue Mar 27, 2023 · 0 comments
Closed

bulej93 - mintDepositInQueue doesnt charge deposit fee #99

sherlock-admin opened this issue Mar 27, 2023 · 0 comments
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label High A valid High severity issue Reward A payout will be made for this issue

Comments

@sherlock-admin
Copy link
Contributor

sherlock-admin commented Mar 27, 2023

bulej93

high

mintDepositInQueue doesnt charge deposit fee

Summary

mintDepositInQueue doesnt charge deposit fee

Vulnerability Detail

in mintDepositQueue which is used to queue for the the next epoch there is deposit fee charged. the deposit function deposit fee is charged for every new epoch. so if someone is looking to escape paying any deposit fee they could just enter a queue and wait for it to be minted

Impact

the protocol may lose out on potential fees

Code Snippet

https://github.com/sherlock-audit/2023-03-Y2K/blob/main/Earthquake/src/v2/Carousel/Carousel.sol#L310

Tool used

Manual Review

Recommendation

charge the deposit fee

Duplicate of #75

@github-actions github-actions bot closed this as completed Apr 3, 2023
@github-actions github-actions bot added High A valid High severity issue Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label labels Apr 3, 2023
@sherlock-admin sherlock-admin added the Reward A payout will be made for this issue label Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label High A valid High severity issue Reward A payout will be made for this issue
Projects
None yet
Development

No branches or pull requests

1 participant