Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile reliant upon requirements.txt and local build #2195

Closed
ppfeister opened this issue Jun 26, 2024 · 4 comments · Fixed by #2216
Closed

Dockerfile reliant upon requirements.txt and local build #2195

ppfeister opened this issue Jun 26, 2024 · 4 comments · Fixed by #2216
Assignees
Labels
bug Something isn't working

Comments

@ppfeister
Copy link
Member

ppfeister commented Jun 26, 2024

Update Dockerfile to build properly with new backend, or pull from PyPI with pip rather than pulling and building from GitHub

@ppfeister ppfeister added the bug Something isn't working label Jun 26, 2024
@ppfeister ppfeister moved this to Backlog in Release 0.15.0 Jun 26, 2024
@ppfeister
Copy link
Member Author

Should also bump Python version to 3.12 and possibly switch to slim alpine

Add env var SHERLOCK_ENV with value Docker for planned additional support

@ppfeister
Copy link
Member Author

@neolight1010 Looks like you switched this from Alpine to deb a couple years ago. You don't happen to remember what the reason was, do you?

@neolight1010
Copy link
Contributor

neolight1010 commented Jun 26, 2024

Hello! We changed it to Debian to fix some issues with the old Alpine image. In summary, Alpine has horrible performance when used in Python projects. The Debian image turned out smaller and simpler to maintain.

You can check out the details here: #1479

@ppfeister ppfeister moved this from Backlog to In review in Release 0.15.0 Jul 1, 2024
@ppfeister ppfeister self-assigned this Jul 1, 2024
@ppfeister
Copy link
Member Author

@neolight1010 I forgot to hit reply apparently ------ thanks for the extra info! Stuck with deb slim on the fixed image due to those findings.

Somewhat curious now how deb would compare to an rpm type image, but I doubt it's worth putting much time into when this works as well as it does.

@ppfeister ppfeister moved this from In review to Approved in Release 0.15.0 Jul 8, 2024
@github-project-automation github-project-automation bot moved this from Approved to Done in Release 0.15.0 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants