Integrate node-geocoder? #24
Comments
agraebe
added a commit
that referenced
this issue
Jun 14, 2016
to come: Reindeers & Requests implementation
agraebe
added a commit
that referenced
this issue
Feb 26, 2017
* adding bluebird missing tests * adding tests for async methods * #33 implementation including tests and updated README.md * adding error handling to samples * resolving conflict for README * update dependency versions * remove publisher and fix gulpfile * #24 first piece with tests to come: Reindeers & Requests implementation * solving #24, #40, #41, #42 - added all methods for #24 including tests - updated READMEs & example files - reworked entire testing architecture for #41 - removed deprecated methods for #42 - added scope checks for #40 * adding tests for #40 * sync updates from master * Added mechanism for token refresh (#47) * added token refresh functionality * added unit test for oauth.js * added unit test for oauthAsync.js * added tests for complete code coverage * code cleanup * Updating dependencies and set engines * Setting tokens to fix #39 * Added implicit surge handling (#49) * added functionality for surge pricing * added implicit surge handling * Changed OAuth2 urls to v2 (#53) * Adding tests for #53 * Dropping node v.1x/iojs in favor of ES6 #30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What do you guys think - would it make sense to integrate node-geocoder to e.g. easily get products by address? I think most people will use it anyways to get lat & lon values for the calls...
I'd propose adding 3 new methods, e.g.:
uber.products.getAllForAddress(address)uber.estimates.getPriceForRouteByAddress(start_address, end_address, [, seats])uber.estimates.getETAForAddress(address [, product_id])In addition to that, some methods might need to be revisited:
uber.requests.create(parameter)uber.requests.getEstimates(parameter)uber.requests.updateByID(request_id, parameter)uber.reminders.create(parameter)uber.reminders.updateByID(reminder_id, parameter).The text was updated successfully, but these errors were encountered: