Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light theme color is off from other (native) icons in URL bar #91

Closed
quassy opened this issue Jul 28, 2018 · 3 comments
Closed

Light theme color is off from other (native) icons in URL bar #91

quassy opened this issue Jul 28, 2018 · 3 comments
Labels

Comments

@quassy
Copy link

quassy commented Jul 28, 2018

Steps to reproduce

  1. Visit a page that has a rss feed
  2. Compare the shade of grey of awesome rss and other native toolbar buttons

Expected behavior

The subscribe button should look native and have the same shade of grey.

Actual behavior

The subscribe button for light theme is brighter #7F7F80 than other buttons like star #666666 in the URL bar.

I believe there are two different shades of grey depending on whether the icon is shown in the URL bar or in the ellipsis menu.

Screenshots and/or logs (see how to open the developer console in your browser)

shadeofgrey

@shgysk8zer0
Copy link
Owner

@quassy I guess they changed this on me. I'm using the actual Photon icon, and I guess I need to do some updates to keep up.

@quassy
Copy link
Author

quassy commented Aug 6, 2018

The fix looks fine for the address bar.

Unfortunately, Firefox uses a different color in the ellipsis menu than in the address bar, so there your icon is too bright now. 🙈

@shgysk8zer0
Copy link
Owner

@quassy I'm not aware of any way of distinguishing between display in the address bar and in the menu. I'll review other add-ons to see if/how they do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants