Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup breaks with long feed titles #93

Closed
quassy opened this issue Jul 29, 2018 · 5 comments
Closed

Popup breaks with long feed titles #93

quassy opened this issue Jul 29, 2018 · 5 comments
Labels

Comments

@quassy
Copy link

quassy commented Jul 29, 2018

Steps to reproduce

  1. Visit a page that has a feed with a very long title, such as the comment feed of this news article.
  2. Click the feed button.

Expected behavior

The text should break and the panel item / button should become taller according to the contents. Alternatively the text should be truncated with an ellipsis.

Actual behavior

The text breaks but the panel item stays the same height and does not adapt to the longer text. Also a vertical scrollbar appears.

Screenshots and/or logs (see how to open the developer console in your browser)

longtitle

@happysurf
Copy link

In my case all is OK, your RSS text is too big in my opinion, try Arial 13.

rss

@shgysk8zer0
Copy link
Owner

This with Arial 14. I wonder if it's a settings issue or an OS issue. Also, judging by the screenshot, I'm guessing you have a very large monitor.

I'll add something to truncate text, but the overflow is a separate issue that I'll not be able to easily reproduce due to the screen size & OS I have access to, if that's part of the issue.

@quassy could you try changing padding/margins, keeping font at the same size, and let me know if any of that changes the overflow & scrolling?

@ssokolow
Copy link

ssokolow commented Aug 3, 2018

Might I suggest this combination of CSS rules?

overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;

Here's the relevant MDN Page.

@quassy
Copy link
Author

quassy commented Aug 6, 2018

In my case all is OK, your RSS text is too big in my opinion, try Arial 13.

My styling and font settings were default.

This with Arial 14. I wonder if it's a settings issue or an OS issue. Also, judging by the screenshot, I'm guessing you have a very large monitor.

Settings weren't changed. Was using Windows 10 and 1366x768 on 13" for that screenshot.

Might I suggest this combination of CSS rules?

The new version works, even though the ellipsis is not shown and the text simply truncated.

@happysurf
Copy link

Settings weren't changed. Was using Windows 10 and 1366x768 on 13" for that screenshot.

OK, the problem is the screen resolution in your case but you can fix the problem changing the font size in extension options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants