Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document engine support #838

Open
Gerrit0 opened this issue Nov 18, 2024 · 1 comment
Open

Document engine support #838

Gerrit0 opened this issue Nov 18, 2024 · 1 comment

Comments

@Gerrit0
Copy link
Contributor

Gerrit0 commented Nov 18, 2024

Some discussion in PRs that I happened to notice seems to indicate that Shiki plans to require Node versions which are newer than the current maintenance LTS release (18, for the next few months)

It would be greatly appreciated if the supported Node versions were documented either on the website or via an engines field in the package.json file.

It would be even better if this behavior was validated by running CI on that version as well.

@slevithan
Copy link
Collaborator

slevithan commented Nov 18, 2024

I believe the context you're referring to was for the new JavaScript engine. However, @antfu and I made changes that avoided relying on Node 20 for the new engine. When it was actually released in Shiki 1.23.0, it required only Node.js 10 to run the generated regexes (since environment support for regex features is detected automatically by the default target: 'auto'). The only case when it requires Node.js 20+ is if you manually change the target option to ES2024 or later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants