Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with NULL columns #70

Merged
merged 4 commits into from
Jul 9, 2021

Conversation

waltervos
Copy link
Contributor

@waltervos waltervos commented Jul 6, 2021

Summary

As reported in #68, the parser stopped on columns with an explicit NULL definition. With my limited understanding of this package, I've tried to create a fix. I've added some columns in the basic test case which all pass.

Added

  • CaselessKeyword for NULL
  • Tests for NULL and NOT NULL columns
  • Added supports for Python 3.9

Changed

  • Detection of NULL/NOT NULL constraint now implemented using an Or match without regular expression.
  • Migrate Travis-CI domain.

Removed

  • Regular expression for NOT NULL constraints

Fixed

Applicable Issues

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #70 (a5f6dea) into master (cce0a1e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #70   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          391       391           
=========================================
  Hits           391       391           
Impacted Files Coverage Δ
ddlparse/ddlparse.py 100.00% <ø> (ø)
ddlparse/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cce0a1e...a5f6dea. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a5f6dea on waltervos:master into cce0a1e on shinichi-takii:master.

@shinichi-takii shinichi-takii self-requested a review July 9, 2021 18:58
@shinichi-takii shinichi-takii added bug Something isn't working enhancement New feature or request labels Jul 9, 2021
Copy link
Owner

@shinichi-takii shinichi-takii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waltervos
Excellent work!!

I added a few fixes.

Thank you!!!

@shinichi-takii shinichi-takii merged commit a1cea99 into shinichi-takii:master Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
3 participants