Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Global FPS variable #16

Open
marenz2569 opened this issue May 3, 2018 · 2 comments
Open

Feature request: Global FPS variable #16

marenz2569 opened this issue May 3, 2018 · 2 comments
Labels
enhancement Enhancement suggestions to the project. low-priority
Projects

Comments

@marenz2569
Copy link
Contributor

I think it is useful if a global FPS variable would be introduced and all animations would use it, well except the ones which do not update the screen for a certain amount of time, like gfx_error.

@vifino
Copy link
Member

vifino commented May 3, 2018

No, this is actually a feature, as we explicitly allow variable refresh rate.

Effects that have no new content available shouldn't have to redraw with no change.
ws2812b's really benefit from the variable refresh rate, as we send updates on demand, no vsync or other timing limits there.

So, well, I don't agree with "all animations".
Perhaps some that can render at really high speeds, those locked at 60 right now, for example.

@marenz2569
Copy link
Contributor Author

Yes this is what I mean. A maximum FPS should be given by the output module.
All other animations that don't need to redraw shall just use there set FPS value.

@vifino vifino added enhancement Enhancement suggestions to the project. low-priority labels May 14, 2018
@vifino vifino added this to To do in Effects May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement suggestions to the project. low-priority
Projects
Effects
  
To do
Development

No branches or pull requests

2 participants