Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgm_pixelflut performance improvements #38

Closed
vifino opened this issue Jun 5, 2018 · 6 comments
Closed

bgm_pixelflut performance improvements #38

vifino opened this issue Jun 5, 2018 · 6 comments
Assignees
@fridtjof @vifino
Labels
enhancement Enhancement suggestions to the project.

Comments

@vifino
Copy link
Member

vifino commented Jun 5, 2018

We might wanna improve the pixelflut performance.
Once #33 is fixed, we can implement a multithreaded pixelflut server like Pixel.

This would allow us to run probably quite a bit faster.
If we implement some network abstractions, it'll be portable as well.

After we get the taskpool working and merged, I'll comb through the pixelflut server and try to make it as fast as I can.
@vifino vifino added the enhancement Enhancement suggestions to the project. label Jun 5, 2018
@vifino vifino mentioned this issue Jun 6, 2018
Merged
4 tasks
@vifino vifino closed this as completed in #39 Jun 7, 2018
@fridtjof
Copy link
Member

fridtjof commented Jun 7, 2018

This isn't done yet

@fridtjof fridtjof reopened this Jun 7, 2018
@vifino
Copy link
Member Author

vifino commented Jun 7, 2018

oof, weird, it closed it.

@fridtjof
Copy link
Member

@20kdc removed the OFFSET command and related fields in the px_buffer_t struct in 6ca049a

Was there a reason for this? We should bring it back otherwise

@fridtjof
Copy link
Member

Also, for some dumb (Apple...) reason, macOS does not have MSG_NOSIGNAL (which was added in 88fb472), but instead has an equivalent called SO_NOSIGPIPE: https://lists.apple.com/archives/macnetworkprog/2002/Dec/msg00091.html

@fridtjof
Copy link
Member

fixed in f543304

@vifino
Copy link
Member Author

vifino commented Jun 12, 2018

With #42 being merged, this is done!!

@vifino vifino closed this as completed Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fridtjof fridtjof

@vifino vifino

Labels
enhancement Enhancement suggestions to the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fridtjof @vifino