Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error thrown if element not visible anymore #197

Closed
ligoo opened this issue Jul 29, 2018 · 0 comments
Closed

Error thrown if element not visible anymore #197

ligoo opened this issue Jul 29, 2018 · 0 comments
Labels

Comments

@ligoo
Copy link

ligoo commented Jul 29, 2018

In the situation of the shepherd box is hidden (per example because some modal showed up and removed the tutorial box) the following error will occur:

Uncaught TypeError: Cannot set property 'hidden' of undefined at Step.hide (shepherd.js:480)

You should wrap these 2 setters by an undefined check before. This should look like this (shepherd.js line 480):

if(typeof this.el !== 'undefined') { // prevent exception if this.el is not available
  this.el.hidden = true; // We need to manually set styles for < IE11 support

  this.el.style.display = 'none';
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants