Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage page in the documentation is missing the tour complete method #2357

Closed
muiscatron opened this issue May 25, 2023 · 3 comments · Fixed by #2508
Closed

Usage page in the documentation is missing the tour complete method #2357

muiscatron opened this issue May 25, 2023 · 3 comments · Fixed by #2508
Labels
documentation

Comments

@muiscatron
Copy link

There is a "complete" method on the tour object, but it's not in the list of methods on the Usage page.
@RobbieTheWagner
Copy link
Member

@muiscatron it is documented here https://shepherdjs.dev/docs/Tour.html#complete but please feel free to add it to the usage doc too, if you would like to open a PR!

@ArslanYM
Copy link

ArslanYM commented Oct 1, 2023

Can I work on this?

@abhayvershwal abhayvershwal mentioned this issue Oct 22, 2023
Merged
@abhayvershwal
Copy link
Contributor

@RobbieTheWagner I have added a PR for this. Does this look good to you?
PR: #2508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added complete method on usage doc abhayvershwal/shepherd
4 participants
@RobbieTheWagner @muiscatron @abhayvershwal @ArslanYM