Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support to keyboard navigation #406

Closed
segux opened this issue Jun 17, 2019 · 6 comments
Closed

Support to keyboard navigation #406

segux opened this issue Jun 17, 2019 · 6 comments
Labels
enhancement

Comments

@segux
Copy link

segux commented Jun 17, 2019

Hi, Do not support keyboard navigation for any reason?
I think it would be a very necessary feature
@RobbieTheWagner
Copy link
Member

Hi @segux we definitely should support it. We have an open issue for supporting a11y and we need to prioritize that.

@segux
Copy link
Author

segux commented Jun 18, 2019 •
edited
Loading

I can help, I have experience with A11y.

@RobbieTheWagner
Copy link
Member

@segux that would be great! Let me know if you have any questions about the code. I am happy to help!

@RobbieTheWagner
Copy link
Member

I implemented arrow navigation here #410

@segux
Copy link
Author

segux commented Jul 1, 2019 •
edited
Loading

Thanks for adding this feature.

But im watching an issue:

  • On left arrow, step goes back but tour continue going next. This is causing creating multiple instances.

And i think you should set optional back step disabled because sometimes i want to make tours only in one direction

@RobbieTheWagner
Copy link
Member

@segux I don't know what you mean. Left arrow only calls back https://github.com/shipshapecode/shepherd/blob/master/src/js/step.js#L249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RobbieTheWagner @segux