-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
controller-gen use of line breaks varies minimally on operator system #832
Comments
Groomed. |
@gabemontero planning to work on #586 which would include this as well |
awesome thanks @MayukhSobo |
Accepting this into the general backlog. |
#873 should also helps working around this issue until The workaround while using the development tools image is to run:
|
@gabemontero @adambkaplan I think the issue was resolved in the meantime. On my local machine, I deleted the CRDs and ran |
thanks for the info @HeavyWombat , that said It is on fedora that we are hitting issues. We are exploring here locally some between @akram and myself when we have cycles But given that, I want to keep this open until we reach a conclusion there. |
@HeavyWombat I tried yesterday on macosx with controller-gen@0.5.0 and the issue still happens. I have no line wrap on macos, but on ubuntu there is line wrap at 80 chars. |
/assign akram |
The update to the v0.6.2 version of controller-gen imo harminized this (= always uses line breaks). @gabemontero can you confirm that you can run this with the right version of controller-gen these days also on your machine without causing changes to line breaks? |
Confirmed!! Added a new Good catch - thanks @SaschaSchwarze0 closing this out |
So make generate-crds behaves differently with respect to line breaks
It works as desired on ubuntu, but not
There is an upstream issue kubernetes-sigs/controller-tools#514 which has been closed but folks are still reporting seeing problems, including @imjasonh from our community
Currently, our github action verify job runs
make generate-crds
to verify consistency, and since that runs on ubuntu, you need to conform to the ubuntu behavior.I've started working on a tailored ubuntu based image where if you mount your local branch into a subsequent container running that image, you can run
make generate-crds
from within the container but update your local branch properly.We could either publish that image to a public shipwright communit repo on quay.io, and then add a make target to leverage that via a container with local mount, or even add a target that builds that image locally, and then runs a container with local mount. My only hiccup there is the install of golang on ubuntu require more interaction besides what the "yes to install prompts" option covers, as it wants you to select geography, etc. Figuring out how to pre-supply those choices so interaction is not involved would be required.
And ultimately, some updating of the contributor guide and maybe PR template to warn contributors of this seems warranted.
The text was updated successfully, but these errors were encountered: