Introduce IBM Container Registry delete #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeavyWombat
added
kind/bug
openshift-ci
bot
added
the
release-note
SaschaSchwarze0
changed the title
The IBM Container Registry (ICR) does not support the standard registry delete call, similar to DockerHub. Instead, a custom API call needs to be used. Add ICR login and ICR delete functions analog to the DockerHub functions. Use the same error message for both custom delete functions. Fix missing `--secret-path` in pull and unpack from private registry test case.
HeavyWombat
force-pushed
the
fix/icr-delete
branch
from
a808671 to
7f6d532
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
SaschaSchwarze0
removed
the
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The IBM Container Registry (ICR) does not support the standard registry delete
call, similar to DockerHub. Instead, a custom API call needs to be used.
Add ICR login and ICR delete functions analog to the DockerHub functions.
Use the same error message for both custom delete functions.
Fix missing
--secret-pathin pull and unpack from private registry test case.In order to (unit) test this locally, set the following environment variables before running Ginkgo:
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes